hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7840) Update PB for prefix support of node attributes
Date Thu, 01 Feb 2018 00:10:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347810#comment-16347810

Naganarasimha G R commented on YARN-7840:

Thanks for the comments [~sunilg] , [~bibinchundatt] & [~cheersyang],  Agree on bibin's
comment and will upload a patch for it.

And for Sunil's comment i had thought about it and based on following points was wondering
whether required
 # If while adding the mapping we are just adding the type for the proto and no value is mapped
and hence no type attached to the Name , so  while submitting the RR what operations are
permitted  ? how to validate.
 # Assume one node sends with No value and other nodes sends it with value. validations cannot
be thought of
 # Did not want the interface to have maps as we do not define the label separately and mapping
with value separately and its a single operation. 

I felt we could have the type with *NodeAttributeProto* and have a map to String Value. Only
place i feel its useful is when we are trying to get unique labels then we have this object
which is having value which does not signify anything. But in all other places it suffices
to have Set/List instead of a Map.


> Update PB for prefix support of node attributes
> -----------------------------------------------
>                 Key: YARN-7840
>                 URL: https://issues.apache.org/jira/browse/YARN-7840
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Weiwei Yang
>            Assignee: Naganarasimha G R
>            Priority: Blocker
>         Attachments: YARN-7840-YARN-3409.001.patch, YARN-7840-YARN-3409.002.patch
> We need to support prefix (namespace) for node attributes, this will add the flexibility
to provide ability to do proper ACL, avoid naming conflicts etc.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message