From yarn-issues-return-136840-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Jan 31 20:59:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 5F018180662 for ; Wed, 31 Jan 2018 20:59:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4F588160C2C; Wed, 31 Jan 2018 19:59:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 97D71160C55 for ; Wed, 31 Jan 2018 20:59:04 +0100 (CET) Received: (qmail 26654 invoked by uid 500); 31 Jan 2018 19:59:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 26541 invoked by uid 99); 31 Jan 2018 19:59:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jan 2018 19:59:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0862619876E for ; Wed, 31 Jan 2018 19:59:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id wqjIakWDZMmz for ; Wed, 31 Jan 2018 19:59:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 507F85F397 for ; Wed, 31 Jan 2018 19:59:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8CB3DE019C for ; Wed, 31 Jan 2018 19:59:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4B822240F2 for ; Wed, 31 Jan 2018 19:59:00 +0000 (UTC) Date: Wed, 31 Jan 2018 19:59:00 +0000 (UTC) From: "Konstantinos Karanasos (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-7778) Merging of constraints defined at different levels MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-7778?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16347= 514#comment-16347514 ]=20 Konstantinos Karanasos commented on YARN-7778: ---------------------------------------------- Thanks for the patch, [~cheersyang]. A couple of comments: * Let's rename the getResourceConstraint() to something like getMultilevel= Constraint? Also the initial part of the comment=C2=A0"Retrieve the placeme= nt constraint of a given scheduling request from the PCM point of view" cou= ld be made more like "Consider all levels of constraints (resource request,= app, cluster) and return a merged constraint". This is because we can also= return a merged constraint of app and cluster level, even if there are no = resource request constraints. * I would also change the signature of the method to add directly a Constr= aint coming from the resource request and a set of tags, rather than pass t= he SchedulingRequest object. This way we make clear that the set of tags is= separate from the specific constraint. * Do we need the "Remove all null or duplicate constraints"? I was thinkin= g that this should belong to a separate step that will do constraint simpli= fication/minimization. If we keep it, I would suggest to put it in a separa= te method in the PCM, so that we can use it elsewhere too or extend it in t= he future easily. > Merging of constraints defined at different levels > -------------------------------------------------- > > Key: YARN-7778 > URL: https://issues.apache.org/jira/browse/YARN-7778 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Konstantinos Karanasos > Assignee: Weiwei Yang > Priority: Major > Attachments: Merge Constraints Solution.pdf, YARN-7778-YARN-7812.= 001.patch, YARN-7778-YARN-7812.002.patch > > > When we have multiple constraints defined for a given set of allocation t= ags at different levels (i.e., at the cluster, the application or the sched= uling request level), we need to merge those constraints. > Defining constraint levels as cluster > application > scheduling request,= constraints defined at lower levels should only be more restrictive than t= hose of higher levels. Otherwise the allocation should fail. > For example, if there is an application level constraint that allows no m= ore than 5 HBase containers per rack, a scheduling request can further rest= rict that to 3 containers per rack but not to 7 containers per rack. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org