From yarn-issues-return-135330-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Fri Jan 19 10:17:10 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 092C1180607 for ; Fri, 19 Jan 2018 10:17:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id ED45B160C28; Fri, 19 Jan 2018 09:17:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3EECB160C27 for ; Fri, 19 Jan 2018 10:17:09 +0100 (CET) Received: (qmail 72466 invoked by uid 500); 19 Jan 2018 09:17:08 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 72455 invoked by uid 99); 19 Jan 2018 09:17:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jan 2018 09:17:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BE6911A08AC for ; Fri, 19 Jan 2018 09:17:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id qADCyof8lxoV for ; Fri, 19 Jan 2018 09:17:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3C0715F23C for ; Fri, 19 Jan 2018 09:17:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AE5FFE0FBF for ; Fri, 19 Jan 2018 09:17:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DDAAD241DE for ; Fri, 19 Jan 2018 09:17:03 +0000 (UTC) Date: Fri, 19 Jan 2018 09:17:03 +0000 (UTC) From: "Konstantinos Karanasos (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-7774) Miscellaneous fixes to the PlacementProcessor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-7774?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16331= 969#comment-16331969 ]=20 Konstantinos Karanasos commented on YARN-7774: ---------------------------------------------- Thanks [~asuresh] for the patch. Looks good overall, some=C2=A0comments: * Do we really need the CircularIterator? It seems to me that you can have= a normal iterator initialized outside the for loop and then each time hasN= ext()=3Dfalse, you can re-initialize it.=C2=A0But maybe I am missing someth= ing. * For what [~cheersyang] mentioned about not being affinity friendly, you = could make a check whether the constraint has minCardinality>0 and scope=3D= NODE, and then keep the iterator at the same place in such a case. But if y= ou feel it is an over-optimization for the time being, I am fine tackling i= t in another JIRA. Up to you. * Do we clean up the black list for each tag? It seems that black-listing = can change based on the allocations that have been done so far, so we might= need to use it carefully. > Miscellaneous fixes to the PlacementProcessor > --------------------------------------------- > > Key: YARN-7774 > URL: https://issues.apache.org/jira/browse/YARN-7774 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Arun Suresh > Assignee: Arun Suresh > Priority: Blocker > Attachments: YARN-7774-YARN-6592.001.patch, YARN-7774-YARN-6592.0= 02.patch, YARN-7774-YARN-6592.003.patch, YARN-7774-YARN-6592.004.patch > > > JIRA to track the following minor changes: > * Scheduler must normalize requests that are made using the {{attemptAllo= cationOnNode}} method. > * Currently, the placement algorithm resets the node iterator for each re= quest. The Placement Algorithm should either shuffle the node iterator OR u= se a circular iterator - to ensure a) more nodes are looked at and b) bias = against placing too many containers on the same node > * Add a placement retry loop for rejected requests - since there are case= s especially, when Constraints will be satisfied after a subsequent request= has been placed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org