From yarn-issues-return-134564-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Jan 10 19:38:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 91DBA18072F for ; Wed, 10 Jan 2018 19:38:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 81BB6160C2E; Wed, 10 Jan 2018 18:38:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C64A3160C1E for ; Wed, 10 Jan 2018 19:38:03 +0100 (CET) Received: (qmail 65359 invoked by uid 500); 10 Jan 2018 18:38:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 65348 invoked by uid 99); 10 Jan 2018 18:38:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 18:38:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8A8F2C1783 for ; Wed, 10 Jan 2018 18:38:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id xGweXJvGrebs for ; Wed, 10 Jan 2018 18:38:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2659C5F36B for ; Wed, 10 Jan 2018 18:38:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6D775E0F4F for ; Wed, 10 Jan 2018 18:38:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2864C274D6 for ; Wed, 10 Jan 2018 18:38:00 +0000 (UTC) Date: Wed, 10 Jan 2018 18:38:00 +0000 (UTC) From: "Shane Kumpf (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-7717) Add configuration consistency for module.enabled and docker.privileged-containers.enabled MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320810#comment-16320810 ] Shane Kumpf commented on YARN-7717: ----------------------------------- Thanks for the patch [~ebadger]! Overall it looks good. Couple comments. I'm curious if using strcasecmp might give us more flexibility in how users define these? does that introduce portability concerns? or is the desire only to support true/True? Also, the documentation only refers to 0/1, I think that should be updated as well. > Add configuration consistency for module.enabled and docker.privileged-containers.enabled > ----------------------------------------------------------------------------------------- > > Key: YARN-7717 > URL: https://issues.apache.org/jira/browse/YARN-7717 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 3.0.0 > Reporter: Yesha Vora > Assignee: Eric Badger > Attachments: YARN-7717.001.patch > > > container-executor.cfg has two properties related to dockerization. > 1) module.enabled = true/false > 2) docker.privileged-containers.enabled = 1/0 > Here, both property takes different value to enable / disable feature. Module enabled take true/false string while docker.privileged-containers.enabled takes 1/0 integer value. > This properties behavior should be consistent. Both properties should have true or false string as value to enable or disable feature/ -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org