From yarn-issues-return-135447-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Sun Jan 21 17:46:10 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 32239180652 for ; Sun, 21 Jan 2018 17:46:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 21D30160C32; Sun, 21 Jan 2018 16:46:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 70FE1160C24 for ; Sun, 21 Jan 2018 17:46:09 +0100 (CET) Received: (qmail 94409 invoked by uid 500); 21 Jan 2018 16:46:08 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 94398 invoked by uid 99); 21 Jan 2018 16:46:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 21 Jan 2018 16:46:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D05FAC194F for ; Sun, 21 Jan 2018 16:46:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.711 X-Spam-Level: X-Spam-Status: No, score=-108.711 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ZyUEK1nwXMnp for ; Sun, 21 Jan 2018 16:46:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4FA8B5F58D for ; Sun, 21 Jan 2018 16:46:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 36415E0E34 for ; Sun, 21 Jan 2018 16:46:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8108521208 for ; Sun, 21 Jan 2018 16:46:02 +0000 (UTC) Date: Sun, 21 Jan 2018 16:46:02 +0000 (UTC) From: "Manikandan R (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-6492) Generate queue metrics for each partition MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-6492?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16333= 591#comment-16333591 ]=20 Manikandan R commented on YARN-6492: ------------------------------------ [~Naganarasimha] Thanks for your review and suggestions. {quote}Though the way we want to get the metrics output is correct i am not= happy to have another class which is just a copy of QueueMetrics and nomin= al changes to capture the Partition information. I was thinking PartitionQu= eueMetrics is just a holder for QueueMetrics and Queue metrics having the c= hanges to incorporate the Partition information too.{quote} I've been trying to think through this to see how I can simplify overall ch= anges after our offline discussions.=C2=A0I did started with couple of metr= ics in this direction, looks like we could accommodate this in QueueMetrics= class and try to avoid PartitionMetrics class.=20 {quote}I think the assumption that queue metrics is created only during the= creation of constructor is wrong as partition can be added dynamically. he= nce if the given queuemetrics objects are not present for a given partition= we need to create it.{quote} Ok, As and when any new partition gets added, JMX metrics o/p can show metr= ics related to those partitions. Till those partitions being used, metrics = (values) would be 0. {quote}Do we really require "enablePartitionMetrics" in the QueueMatrix ? I= MO its sufficient to have "string partition" class member and by having def= ault value as "DEFAULT". May be we can further discuss on it.{quote} Ok. Should be fine as partition is "default" by default. In case there are = no partitions, still JMX o/p can have PartitionQueueMetrics for "default" p= artition. Also, In the meantime, We would like to hear thoughts from Community to ens= ure we are on the right direction. > Generate queue metrics for each partition > ----------------------------------------- > > Key: YARN-6492 > URL: https://issues.apache.org/jira/browse/YARN-6492 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler > Reporter: Jonathan Hung > Assignee: Manikandan R > Priority: Major > Attachments: YARN-6492.001.patch, YARN-6492.002.patch, partition_= metrics.txt > > > We are interested in having queue metrics for all partitions. Right now e= ach queue has one QueueMetrics object which captures metrics either in defa= ult partition or across all partitions. (After YARN-6467 it will be in defa= ult partition) > But having the partition metrics would be very useful. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org