hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bibin A Chundatt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7840) Update PB for prefix support of node attributes
Date Tue, 30 Jan 2018 10:55:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344875#comment-16344875

Bibin A Chundatt commented on YARN-7840:

Thank you [~Naganarasimha] for patch

  Minor comment
159	  @Override
160	  public void setAttributePrefix(String attributePrefix) {
161	    maybeInitBuilder();
162	    builder.setAttributeName(attributePrefix);
163	  }
    if (attributePrefix == null) {
 # IIUC we should be clearing attribute if its null as above
 # Since the default value for attribute prefix is EMPTY any thoughts on setting the default
value as EMPTY in proto too?? Else we might need to check in multiple places for EMPTY/NULL
in future to identify default value

> Update PB for prefix support of node attributes
> -----------------------------------------------
>                 Key: YARN-7840
>                 URL: https://issues.apache.org/jira/browse/YARN-7840
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Weiwei Yang
>            Assignee: Naganarasimha G R
>            Priority: Blocker
>         Attachments: YARN-7840-YARN-3409.001.patch, YARN-7840-YARN-3409.002.patch
> We need to support prefix (namespace) for node attributes, this will add the flexibility
to provide ability to do proper ACL, avoid naming conflicts etc.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message