hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantinos Karanasos (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7788) Refactor AllocationTagsManager to move management of temp tags to a separate class
Date Tue, 23 Jan 2018 00:06:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335188#comment-16335188
] 

Konstantinos Karanasos commented on YARN-7788:
----------------------------------------------

Thanks for the patch, [~asuresh].

+1 for separating the refactoring from YARN-7783.

Patch looks good. Only comment is that I think you don't need to instantiate the EphemeralTagsManager
each time. You can keep a single copy at the DefaultPlacementAlgo and use that instance each
time you call the placement algorithm.

> Refactor AllocationTagsManager to move management of temp tags to a separate class
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-7788
>                 URL: https://issues.apache.org/jira/browse/YARN-7788
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>            Priority: Major
>         Attachments: YARN-7788-YARN-6592.001.patch, YARN-7788-YARN-6592.002.patch
>
>
> Splitting YARN-7783 to move the refactoring to a separate JIRA



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message