hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weiwei Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7757) Refactor NodeLabelsProvider to be more generic and reusable for node attributes providers
Date Wed, 31 Jan 2018 01:08:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346083#comment-16346083

Weiwei Yang commented on YARN-7757:

Hi [~sunilg]

Thanks for your comments, 
bq. we cant deny a possibility of multi scripts for different types of attributes
Agree, itmakes sense.

bq.Could we have permission checks etc
We already have it in the patch, by reusing existing check code from labels. Please see {{AbstractNodeDescriptorsProvider#verifyConfiguredScript}},
this is called in both script based providers implementation (labels and attributes).

bq. If the script is not back within next periodic check, we can interrupt and fail the op
Also make sense.

I suggest we track such enhancements as described in #1 and #3 in another lower priority task,
this one is focus on the refactoring of existing code which is a blocker for the rest.
Do you have any other comments?


> Refactor NodeLabelsProvider to be more generic and reusable for node attributes providers
> -----------------------------------------------------------------------------------------
>                 Key: YARN-7757
>                 URL: https://issues.apache.org/jira/browse/YARN-7757
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Major
>         Attachments: YARN-7757-YARN-3409.001.patch, YARN-7757-YARN-3409.002.patch, YARN-7757-YARN-3409.003.patch,
YARN-7757-YARN-3409.004.patch, nodeLabelsProvider_refactor_class_hierarchy.pdf
> Propose to do refactor on {{NodeLabelsProvider}}, {{AbstractNodeLabelsProvider}} to be
more generic, so node attributes providers can reuse these interface/abstract classes.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message