hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7757) Refactor NodeLabelsProvider to be more generic and reusable for node attributes providers
Date Tue, 30 Jan 2018 16:28:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345324#comment-16345324
] 

Sunil G commented on YARN-7757:
-------------------------------

Thanks [~cheersyang]

Few general comments on config. I am still reviewing the patch and ll share comments going
forward if any.
 # Are we expecting only one script value for {{yarn.nodemanager.node-attributes.provider.script.path}}
. I think we cant deny a possibility of multi scripts for different types of attributes. What
do you think?
 # Since we accepts some command line opts, we better have to have some validation to avoid
risking malicious scripts in {{yarn.nodemanager.node-attributes.provider.script.opts}}. Could
we have permission checks etc?
 # Do we need to have {{yarn.nodemanager.node-attributes.provider.fetch-timeout-ms}}. If the
script is not back within next periodic check, we can interrupt and fail the op. In case of
-1 value to disable periodic value, 60seconds should be good enough to wait? Thoughts?

> Refactor NodeLabelsProvider to be more generic and reusable for node attributes providers
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-7757
>                 URL: https://issues.apache.org/jira/browse/YARN-7757
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Major
>         Attachments: YARN-7757-YARN-3409.001.patch, YARN-7757-YARN-3409.002.patch, YARN-7757-YARN-3409.003.patch,
YARN-7757-YARN-3409.004.patch, nodeLabelsProvider_refactor_class_hierarchy.pdf
>
>
> Propose to do refactor on {{NodeLabelsProvider}}, {{AbstractNodeLabelsProvider}} to be
more generic, so node attributes providers can reuse these interface/abstract classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message