hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shane Kumpf (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7717) Add configuration consistency for module.enabled and docker.privileged-containers.enabled
Date Wed, 10 Jan 2018 18:38:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320810#comment-16320810
] 

Shane Kumpf commented on YARN-7717:
-----------------------------------

Thanks for the patch [~ebadger]! Overall it looks good. Couple comments. I'm curious if using
strcasecmp might give us more flexibility in how users define these? does that introduce portability
concerns? or is the desire only to support true/True? Also, the documentation only refers
to 0/1, I think that should be updated as well.

> Add configuration consistency for module.enabled and docker.privileged-containers.enabled
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-7717
>                 URL: https://issues.apache.org/jira/browse/YARN-7717
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Yesha Vora
>            Assignee: Eric Badger
>         Attachments: YARN-7717.001.patch
>
>
> container-executor.cfg has two properties related to dockerization. 
> 1)  module.enabled = true/false
> 2) docker.privileged-containers.enabled = 1/0
> Here, both property takes different value to enable / disable feature. Module enabled
take true/false string while docker.privileged-containers.enabled  takes 1/0 integer value.

> This properties behavior should be consistent. Both properties should have true or false
string as value to enable or disable feature/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message