hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "lujie (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-7703) Apps killed from the NEW state are not recorded in the state store
Date Wed, 10 Jan 2018 03:40:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319651#comment-16319651
] 

lujie edited comment on YARN-7703 at 1/10/18 3:39 AM:
------------------------------------------------------

I attach a patch, this patch do three things:
1. use FinalSavingTransition replace the AppKilledTransition while RMApp receive KILL event
at NEW state.
2.modify the unit test testAppNewKill and testAppStartAfterKilled to adapt the changes.
3. add testAppStartAtFinalSaving: START event can arrive at FINAL_SAVING state.

I also filed [YARN-7726|https://issues.apache.org/jira/browse/YARN-7726] to handle invalid
translation APP_ACCEPTED at state ACCEPTED . 
while fixing [YARN-7726|https://issues.apache.org/jira/browse/YARN-7726], I think the overrided
method onInvalidTranstion should be moved to createNewTestApp, this change will make the unit
test in TestRMAppTransitions more clear and neat.


was (Author: xiaoheipangzi):
I attach a patch, this patch do three things:
1. use FinalSavingTransition replace the AppKilledTransition while RMApp receive KILL event
at NEW state.
2.modify the unit test testAppNewKill and testAppStartAfterKilled
3. add testAppStartAtFinalSaving: START event can arrive at FINAL_SAVING state.

I also filed [YARN-7726|https://issues.apache.org/jira/browse/YARN-7726] to handle invalid
translation APP_ACCEPTED at state ACCEPTED . 
while fixing [YARN-7726|https://issues.apache.org/jira/browse/YARN-7726], I think the overrided
method onInvalidTranstion should be moved to createNewTestApp, this change will make the unit
test in TestRMAppTransitions more clear and neat.

> Apps killed from the NEW state are not recorded in the state store
> ------------------------------------------------------------------
>
>                 Key: YARN-7703
>                 URL: https://issues.apache.org/jira/browse/YARN-7703
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>            Reporter: Jason Lowe
>            Assignee: lujie
>         Attachments: YARN-7703_0.patch
>
>
> While reviewing YARN-7663 I noticed that apps killed from the NEW state skip storing
anything to the RM state store.  That means upon restart and recovery these apps will not
be recovered, so they will simply disappear.  That could be surprising for users.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message