hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7602) NM should reference the singleton JvmMetrics instance
Date Tue, 02 Jan 2018 18:55:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308502#comment-16308502
] 

Mike Drob commented on YARN-7602:
---------------------------------

{code}
+    Assert.assertTrue("initSingleton should return the singleton instance",
+        jvmMetrics1.equals(jvmMetrics2));
{code}
Prefer assertEquals instead for clearer failure messages.

Add a test for what happens if there are two calls to initSingleton with different prefixes?

> NM should reference the singleton JvmMetrics instance
> -----------------------------------------------------
>
>                 Key: YARN-7602
>                 URL: https://issues.apache.org/jira/browse/YARN-7602
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.0.0-beta1
>            Reporter: Haibo Chen
>            Assignee: Haibo Chen
>         Attachments: YARN-7602.00.patch, YARN-7602.01.patch
>
>
> NM does not reference the singleton JvmMetrics instance in its NodeManagerMetrics. This
will easily cause NM to crash if any of the node manager components tries to register JvmMetrics.
An example of this is TimelineCollectorManager that hosts a HBaseClient that registers JvmMetrics
again. See HBASE-19409 for details.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message