Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 28 Dec 2017 15:52:00 +0000 (UTC)
From: "Panagiotis Garefalakis (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13127122.1514228156000.542113.1514476320070@Atlassian.JIRA>
In-Reply-To: <JIRA.13127122.1514228156000@Atlassian.JIRA>
References: <JIRA.13127122.1514228156000@Atlassian.JIRA> <JIRA.13127122.1514228156783@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (YARN-7682) Expose canAssign method in the
 PlacementConstraintManager
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 28 Dec 2017 15:52:05 -0000


    [ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305548#comment-16305548 ] 

Panagiotis Garefalakis edited comment on YARN-7682 at 12/28/17 3:51 PM:
------------------------------------------------------------------------

Attaching a first version of the patch.
PlacementConstaintsUtl class is now returning if a node is a valid placement for a set of allocationTags.
Currently supporting SingleConstaints as discussed and both scopes Node and Rack.
An interesting fact is during the first allocation where no tags exist affinity would always fail if we wanted to ensure minCardinality is always >=1. I fixed that by checking if it is the first application allocation.

However for more generic scenarios like cardinality there are different ways to tackle the problem. For example:
{code:java}
 {NODE, 2, 10,allocationTag("spark")} 
{code}
should we promote affinity on Nodes where cMin is <= 2 or just ensure cMax is <= 10 ?
[~asuresh] [~kkaranasos] Thoughts?


was (Author: pgaref):
Attaching a first version of the patch.
PlacementConstaintsUtl class is now returning if a node is a valid placement for a set of allocationTags.
Currently supporting SingleConstaints as discussed and both scopes Node and Rack.
An interesting fact is during the first allocation where no tags exist affinity would always fail if we wanted to ensure minCardinality is always >=1. I fixed that by checking if it is the first application allocation.
However for more generic scenarios like cardinality there are different ways to tackle the problem. For example {NODE, 2, 10,allocationTag("spark")} should we promote affinity on Nodes where cMin is <= 2 or just ensure cMax is <= 10 ?
[~asuresh] [~kkaranasos] Thoughts?

> Expose canAssign method in the PlacementConstraintManager
> ---------------------------------------------------------
>
>                 Key: YARN-7682
>                 URL: https://issues.apache.org/jira/browse/YARN-7682
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Panagiotis Garefalakis
>         Attachments: YARN-7682-YARN-6592.001.patch, YARN-7682.wip.patch
>
>
> As per discussion in YARN-7613. Lets expose {{canAssign}} method in the PlacementConstraintManager that takes a sourceTags, applicationId, SchedulerNode and AllocationTagsManager and returns true if constraints are not violated by placing the container on the node.
> I prefer not passing in the SchedulingRequest, since it can have > 1 numAllocations. We want this api to be called for single allocations.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org