Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 15 Dec 2017 22:02:00 +0000 (UTC)
From: "Jason Lowe (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13122184.1512140149000.473065.1513375320713@Atlassian.JIRA>
In-Reply-To: <JIRA.13122184.1512140149000@Atlassian.JIRA>
References: <JIRA.13122184.1512140149000@Atlassian.JIRA> <JIRA.13122184.1512140149419@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-7595) Container launching code suppresses
 close exceptions after writes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 15 Dec 2017 22:02:04 -0000


    [ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293323#comment-16293323 ] 

Jason Lowe commented on YARN-7595:
----------------------------------

+1 for the branch-2.8 patch as well.  I agree the unit test failures are unrelated and verified they pass without this patch.  Committing this.

> Container launching code suppresses close exceptions after writes
> -----------------------------------------------------------------
>
>                 Key: YARN-7595
>                 URL: https://issues.apache.org/jira/browse/YARN-7595
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Jason Lowe
>            Assignee: Jim Brennan
>             Fix For: 3.1.0, 3.0.1
>
>         Attachments: YARN-7595-branch-2.001.patch, YARN-7595-branch-2.8.001.patch, YARN-7595-branch-2.8.002.patch, YARN-7595.001.patch, YARN-7595.002.patch, YARN-7595.003.patch
>
>
> There are a number of places in code related to container launching where the following pattern is used:
> {code}
>   try {
>     ...write to stream outStream...
>   } finally {
>     IOUtils.cleanupWithLogger(LOG, outStream);
>   }
> {code}
> Unfortunately this suppresses any IOException that occurs during the close() method on outStream.  If the stream is buffered or could otherwise fail to finish writing the file when trying to close then this can lead to partial/corrupted data without throwing an I/O error.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org