hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miklos Szegedi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7687) ContainerLogAppender Improvements
Date Fri, 29 Dec 2017 22:07:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-7687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306571#comment-16306571
] 

Miklos Szegedi commented on YARN-7687:
--------------------------------------

Thank you for the patch [~belugabehr].
Please fix the outstanding checkstyle issue.
{code}
49	    isBuffered = (maxEvents > 0);
{code}
I am not sure why this is needed, it adds to the memory footprint. You could just check for
{{maxEvents}} in {{append}} mentioning in a comment that a positive value means that the data
is buffered.
{code}
50	      if (maxEvents > 0) {		
51	        tail = new LinkedList<LoggingEvent>();		
52	      }
{code}
Can you tell me the reason why this check was removed? The lazy creation did actually save
some memory if no buffering is used.

> ContainerLogAppender Improvements
> ---------------------------------
>
>                 Key: YARN-7687
>                 URL: https://issues.apache.org/jira/browse/YARN-7687
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Priority: Trivial
>         Attachments: YARN-7687.1.patch
>
>
> * Use Array-backed collection instead of LinkedList
> * Ignore calls to {{close()}} after the initial call
> * Clear the queue after {{close}} is called to let garbage collection do its magic on
the items inside of it
> * Fix int-to-long conversion issue (overflow)
> * Remove superfluous white space



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message