hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantinos Karanasos (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7669) [API] Introduce interfaces for placement constraint processing
Date Wed, 20 Dec 2017 18:22:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298858#comment-16298858
] 

Konstantinos Karanasos commented on YARN-7669:
----------------------------------------------

Thanks [~asuresh] for updating the patch.
A couple of things:
* Following [~sunilg] comment on using the RejectionReason in multiple occasions, probably
we should give the two reasons a more specific name. Like "constraint_violation_on_node" etc.?
* You mention in the comment of the first enum that it is not retry-able. I think it can be
retry-able, for example if we use global cluster constraints and something changes between
attempts. Also, things get more complicated with inter-application constraints. So, maybe
what we mean but this error is "unsatisfiable user constraints?". Most importantly, will we
be using this enum to decide whether we are retrying placement or is it just for knowing what
went wrong?
* The Algorithm* classes' names seem too generic. I would prefer to add a prefix like Placement
or Constraint to all of them.

> [API] Introduce interfaces for placement constraint processing
> --------------------------------------------------------------
>
>                 Key: YARN-7669
>                 URL: https://issues.apache.org/jira/browse/YARN-7669
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-7669-YARN-6592.001.patch, YARN-7669-YARN-6592.002.patch, YARN-7669-YARN-6592.003.patch,
YARN-7669-YARN-6592.004.patch
>
>
> As per discussions in YARN-7612. This JIRA will introduce the generic interfaces which
will be implemented in YARN-7612



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message