hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun Suresh (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-7669) [API] Introduce interfaces for placement constraint processing
Date Tue, 19 Dec 2017 16:22:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297030#comment-16297030
] 

Arun Suresh edited comment on YARN-7669 at 12/19/17 4:21 PM:
-------------------------------------------------------------

Updating patch based on [~kkaranasos]'s suggestions.

bq. In the ApplicationMasterServiceUtils, I would put the setRejectedSchedulingRequests inside
the first if clause, assuming most responses will not have a rejection.
Actually, the method itself is called, only if there are rejections - which means inside the
method, we can be sure there is a rejection. Also, lets keep it consistent with the remaining
methods.


was (Author: asuresh):
Updating patch based on [~kkaranasos]'s suggestions.

bq. In the ApplicationMasterServiceUtils, I would put the setRejectedSchedulingRequests inside
the first if clause, assuming most responses will not have a rejection.
Actually, if the method itself is called, only if there are rejections - which means inside
the method, we can be sure there is a rejection. Also, lets keep it consistent with the remaining
methods.

> [API] Introduce interfaces for placement constraint processing
> --------------------------------------------------------------
>
>                 Key: YARN-7669
>                 URL: https://issues.apache.org/jira/browse/YARN-7669
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-7669-YARN-6592.001.patch, YARN-7669-YARN-6592.002.patch
>
>
> As per discussions in YARN-7612. This JIRA will introduce the generic interfaces which
will be implemented in YARN-7612



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message