hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun Suresh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7642) Container execution type is not updated after promotion/demotion in NMContext
Date Wed, 13 Dec 2017 13:32:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289261#comment-16289261

Arun Suresh commented on YARN-7642:

[~cheersyang], I was just looking at the code again.
There is only 1 container object for each container in the NM - which can be accessed via
the NMContext (or from the queues in the ContainerScheduler, but both refer to the same object)
Every container update event (either via autoUpdate or AM explicitly asking to update event)
is funneled thru the ContainerManagerImpl::updateContainerInternal() method.
And ultimately, it dispatches an UpdaContainerTokenEvent like so:
   // Dispatch message to Container to actually
        // make the change.
        dispatcher.getEventHandler().handle(new UpdateContainerTokenEvent(
            container.getContainerId(), containerTokenIdentifier,
            isResourceChange, isExecTypeUpdate, isIncrease));

Now, this container token event is handled by the Container object either in the {{UpdateTransition}}
or in the {{NotifyContainerSchedulerOfUpdateTransition}}. In both cases, it looks like the
container's token is updated (the new container token is created by RM and should have the
updated exec type).

> Container execution type is not updated after promotion/demotion in NMContext
> -----------------------------------------------------------------------------
>                 Key: YARN-7642
>                 URL: https://issues.apache.org/jira/browse/YARN-7642
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.9.0
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Critical
>         Attachments: YARN-7642.001.patch
> Found this bug while working on YARN-7617. After calling API to promote a container from
OPPORTUNISTIC to GUARANTEED, node manager web page still shows the container execution type
as OPPORTUNISTIC. Looks like the container execution type in NMContext was not updated accordingly.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message