hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7473) Implement Framework and policy for capacity management of auto created queues
Date Thu, 07 Dec 2017 20:56:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282515#comment-16282515
] 

Wangda Tan commented on YARN-7473:
----------------------------------

Thanks [~suma.shivaprasad], for updating the patch. 

I suggest to revert this part:

{code}
	198	
199	      //If absolute capacity is 0 for a leaf queue (could be a managed leaf
200	      // queue, then use the leaf queue's template capacity to compute
201	      // guaranteed resource for used capacity)
202	      float absoluteCapacity = queueCapacities.getAbsoluteCapacity
203	          (nodePartition);
204	      if (Float.compare(absoluteCapacity,
205	          0f) == 0 && childQueue instanceof AutoCreatedLeafQueue) {
206	        ManagedParentQueue parentQueue = (ManagedParentQueue)
207	            childQueue.getParent();
208	        QueueCapacities leafQueueCapacities = parentQueue.getLeafQueueTemplate()
209	            .getQueueCapacities();
210	        absoluteCapacity = leafQueueCapacities.getAbsoluteCapacity
211	            (nodePartition);
212	      }
{code}. 

Other than that, patch looks good, could you take care of findbugs/checkstyle/unit test issues?

> Implement Framework and policy for capacity management of auto created queues 
> ------------------------------------------------------------------------------
>
>                 Key: YARN-7473
>                 URL: https://issues.apache.org/jira/browse/YARN-7473
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacity scheduler
>            Reporter: Suma Shivaprasad
>            Assignee: Suma Shivaprasad
>         Attachments: YARN-7473.1.patch, YARN-7473.10.patch, YARN-7473.11.patch, YARN-7473.12.patch,
YARN-7473.12.patch, YARN-7473.13.patch, YARN-7473.14.patch, YARN-7473.15.patch, YARN-7473.2.patch,
YARN-7473.3.patch, YARN-7473.4.patch, YARN-7473.5.patch, YARN-7473.6.patch, YARN-7473.7.patch,
YARN-7473.8.patch, YARN-7473.9.patch
>
>
> This jira mainly addresses the following
>  
> 1.Support adding pluggable policies on parent queue for dynamically managing capacity/state
for leaf queues.
> 2. Implement  a default policy that manages capacity based on pending applications and
either grants guaranteed or zero capacity to queues based on parent's available guaranteed
capacity.
> 3. Integrate with SchedulingEditPolicy framework to trigger this periodically and signal
scheduler to take necessary actions for capacity/queue management.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message