hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7383) Node resource not parsed correctly for resource names containing dot
Date Wed, 13 Dec 2017 11:04:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289097#comment-16289097
] 

Sunil G commented on YARN-7383:
-------------------------------

TestPBImplRecords is passing locally. I ll still rerun jenkins to cross check.

> Node resource not parsed correctly for resource names containing dot
> --------------------------------------------------------------------
>
>                 Key: YARN-7383
>                 URL: https://issues.apache.org/jira/browse/YARN-7383
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Jonathan Hung
>            Assignee: Gergely Novák
>         Attachments: YARN-7383.001.patch, YARN-7383.002.patch
>
>
> Currently when getting resource capabilities in {{node-resources.xml}}, the following
parsing code is used: {noformat}    String[] parts = prop.split("\\.");
>     LOG.info("Found resource entry " + prop);
>     if (parts.length == 4) {
>       String resourceType = parts[3];
>       if (!nodeResources.containsKey(resourceType)) {
>         nodeResources
>             .put(resourceType, ResourceInformation.newInstance(resourceType));
>       }
>       String units = getUnits(value);
>       Long resourceValue =
>           Long.valueOf(value.substring(0, value.length() - units.length()));
>       nodeResources.get(resourceType).setValue(resourceValue);
>       nodeResources.get(resourceType).setUnits(units);
>       if (LOG.isDebugEnabled()) {
>         LOG.debug("Setting value for resource type " + resourceType + " to "
>             + resourceValue + " with units " + units);
>       }
>     }{noformat}
> If resource names contain dots though (e.g. for resource names in a namespace) this will
not parse correctly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message