hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5418) When partial log aggregation is enabled, display the list of aggregated files on the container log page
Date Wed, 13 Dec 2017 00:01:01 GMT

    [ https://issues.apache.org/jira/browse/YARN-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288501#comment-16288501
] 

Wangda Tan commented on YARN-5418:
----------------------------------

Thanks [~xgong], in general patch looks good except few minor comments: 

1. getLogStartTime/getLogEndTime : {{Block html}} param is not necessary.

2.    
{code}
      try {
        fileController = this.factory.getFileControllerForRead(
            appId, $(APP_OWNER));
        foundAggregatedLogs = true;
      } catch (Exception fnf) {
        // Do Nothing
      }
{code}

It's better to catch IOException. 

3. Findbugs / java docs. 

> When partial log aggregation is enabled, display the list of aggregated files on the
container log page
> -------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5418
>                 URL: https://issues.apache.org/jira/browse/YARN-5418
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Xuan Gong
>         Attachments: Screen Shot 2017-03-06 at 1.38.04 PM.png, YARN-5418.1.patch, YARN-5418.2.patch,
YARN-5418.3.patch, YARN-5418.4.branch-2.patch, YARN-5418.branch-2.4.patch, YARN-5418.trunk.4.patch
>
>
> The container log pages lists all files. However, as soon as a file gets aggregated -
it's no longer available on this listing page.
> It will be useful to list aggregated files as well as the current set of files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message