Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 16 Nov 2017 20:00:00 +0000 (UTC)
From: "Wangda Tan (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13115992.1509728241000.259005.1510862400411@Atlassian.JIRA>
In-Reply-To: <JIRA.13115992.1509728241000@Atlassian.JIRA>
References: <JIRA.13115992.1509728241000@Atlassian.JIRA> <JIRA.13115992.1509728241493@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-7438) Additional changes to make
 SchedulingPlacementSet agnostic to ResourceRequest / placement algorithm
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 16 Nov 2017 20:00:07 -0000


    [ https://issues.apache.org/jira/browse/YARN-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255878#comment-16255878 ] 

Wangda Tan commented on YARN-7438:
----------------------------------

[~sunilg], 

bq. lastPendingAsk and newPendingAsk seems a little tricky to understand and its per Scheduler Key. Could we rename this better.
I just more explanations to PendingAskUpdateResult, please let me know if it is sufficient.

bq. Once we save set of resource requests associated with a given container, it might have various resource names (node local, rack local etc). But ANY will be common.
I agree with this as well as [~asuresh]'s suggestion. Under the context of YARN-6592, we may need SchedulingRequest (or request-agnostic class) to save results. So I prefer to keep it as-is and revisit this in the future. [~asuresh], any suggestions here?

bq. lastPendingAsk could be cached?
I'm quite sure what does this mean, could you elaborate? 

[~asuresh],
bq. We should change the name of AppPlacementAllocator#updateResourceRequests to updatePendingAsk
Done. 

Attached ver.2 patch. Please kindly review.


> Additional changes to make SchedulingPlacementSet agnostic to ResourceRequest / placement algorithm
> ---------------------------------------------------------------------------------------------------
>
>                 Key: YARN-7438
>                 URL: https://issues.apache.org/jira/browse/YARN-7438
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-7438.001.patch
>
>
> In additional to YARN-6040, we need to make changes to SchedulingPlacementSet to make it: 
> 1) Agnostic to ResourceRequest (so once we have YARN-6592 merged, we can add new SchedulingPlacementSet implementation in parallel with LocalitySchedulingPlacementSet to use/manage new requests API)
> 2) Agnostic to placement algorithm (now it is bind to delayed scheduling, we should update APIs to make sure new placement algorithms such as complex placement algorithms can be implemented by using SchedulingPlacementSet).


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org