Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 15 Nov 2017 22:20:01 +0000 (UTC)
From: "Arun Suresh (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13115992.1509728241000.249696.1510784401560@Atlassian.JIRA>
In-Reply-To: <JIRA.13115992.1509728241000@Atlassian.JIRA>
References: <JIRA.13115992.1509728241000@Atlassian.JIRA> <JIRA.13115992.1509728241493@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-7438) Additional changes to make
 SchedulingPlacementSet agnostic to ResourceRequest / placement algorithm
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 15 Nov 2017 22:20:06 -0000


    [ https://issues.apache.org/jira/browse/YARN-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254323#comment-16254323 ] 

Arun Suresh commented on YARN-7438:
-----------------------------------

[~leftnoteasy], Some more comments:
* We should change the name of {{AppPlacementAllocator#updateResourceRequests}} to {{updatePendingAsk}}
* Echoing Sunil's concern:
bq. Once we save set of resource requests associated with a given container, it might have various resource names (node local, rack local etc). But ANY will be common 
I tried to work around this in the OpportunisticContainerAllocator using an [EnrichedResourceRequest|https://github.com/apache/hadoop/blob/branch-2.9.0/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/scheduler/OpportunisticContainerAllocator.java#L235-L282], which I create and populate [here|https://github.com/apache/hadoop/blob/branch-2.9.0/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/scheduler/OpportunisticContainerContext.java#L127-L159]
But I am guessing once YARN-7448 goes in, you should just merge everything into ScheduleingRequest


> Additional changes to make SchedulingPlacementSet agnostic to ResourceRequest / placement algorithm
> ---------------------------------------------------------------------------------------------------
>
>                 Key: YARN-7438
>                 URL: https://issues.apache.org/jira/browse/YARN-7438
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-7438.001.patch
>
>
> In additional to YARN-6040, we need to make changes to SchedulingPlacementSet to make it: 
> 1) Agnostic to ResourceRequest (so once we have YARN-6592 merged, we can add new SchedulingPlacementSet implementation in parallel with LocalitySchedulingPlacementSet to use/manage new requests API)
> 2) Agnostic to placement algorithm (now it is bind to delayed scheduling, we should update APIs to make sure new placement algorithms such as complex placement algorithms can be implemented by using SchedulingPlacementSet).


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org