Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1E6A5200D3A for ; Wed, 15 Nov 2017 20:17:15 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1D3A2160BF6; Wed, 15 Nov 2017 19:17:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 63C37160BE4 for ; Wed, 15 Nov 2017 20:17:14 +0100 (CET) Received: (qmail 52584 invoked by uid 500); 15 Nov 2017 19:17:13 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 52573 invoked by uid 99); 15 Nov 2017 19:17:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Nov 2017 19:17:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A69DD180833 for ; Wed, 15 Nov 2017 19:17:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id qsor-zcBTWll for ; Wed, 15 Nov 2017 19:17:12 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3778661189 for ; Wed, 15 Nov 2017 19:17:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E8FDDE0383 for ; Wed, 15 Nov 2017 19:17:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id ACE2924736 for ; Wed, 15 Nov 2017 19:17:01 +0000 (UTC) Date: Wed, 15 Nov 2017 19:17:01 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-6953) Clean up ResourceUtils.setMinimumAllocationForMandatoryResources() and setMaximumAllocationForMandatoryResources() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 15 Nov 2017 19:17:15 -0000 [ https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253981#comment-16253981 ] Hudson commented on YARN-6953: ------------------------------ SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13239 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/13239/]) YARN-6953. Clean up (templedf: rev e094eb74b9e7d8c3c6f1990445d248b062cc230b) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/util/resource/ResourceUtils.java > Clean up ResourceUtils.setMinimumAllocationForMandatoryResources() and setMaximumAllocationForMandatoryResources() > ------------------------------------------------------------------------------------------------------------------ > > Key: YARN-6953 > URL: https://issues.apache.org/jira/browse/YARN-6953 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Affects Versions: YARN-3926 > Reporter: Daniel Templeton > Assignee: Manikandan R > Priority: Minor > Labels: newbie > Fix For: 3.1.0, 3.0.1 > > Attachments: YARN-6953-YARN-3926-WIP.patch, YARN-6953-YARN-3926.001.patch, YARN-6953-YARN-3926.002.patch, YARN-6953-YARN-3926.003.patch, YARN-6953-YARN-3926.004.patch, YARN-6953-YARN-3926.005.patch, YARN-6953-YARN-3926.006.patch, YARN-6953.007.patch, YARN-6953.008.patch, YARN-6953.009.patch > > > The {{setMinimumAllocationForMandatoryResources()}} and {{setMaximumAllocationForMandatoryResources()}} methods are quite convoluted. They'd be much simpler if they just handled CPU and memory manually instead of trying to be clever about doing it in a loop. There are also issues, such as the log warning always talking about memory or the last element of the inner array being a copy of the first element. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org