hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wilfred Spiegelenburg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7513) FindBugs in FSAppAttempt.getWeight()
Date Fri, 17 Nov 2017 00:56:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256238#comment-16256238
] 

Wilfred Spiegelenburg commented on YARN-7513:
---------------------------------------------

Holding the scheduler lock to get the demand for an application attempt does not seem correct.
The call out used to come from the FSAppAttempt back to the scheduler and then was using FSAppAttempt
for details. Which could have been the reason. However there was no locking at all on this
call before YARN-3139 was implemented. Current releases of CDH do not have YARN-3139 and we
do not have any issues in those releases.
Based on all that and the fact that we use private FSAppAttempt variables {{demand}} and {{appPriority}}
I doubt that there will be a need now or that we ever had a reason for the locking.

Test failures are not related to this jira.

> FindBugs in FSAppAttempt.getWeight()
> ------------------------------------
>
>                 Key: YARN-7513
>                 URL: https://issues.apache.org/jira/browse/YARN-7513
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 3.1.0
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wilfred Spiegelenburg
>            Priority: Minor
>         Attachments: YARN-7513.001.patch
>
>
> With the change from YARN-7414 a new FindBugs warning was introduced.
> The code that was moved from the FairScheduler to the FSAppAttempt can also be simplified
by removing the unneeded locking.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message