hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-7442) [YARN-7069] Limit format of resource type name
Date Thu, 09 Nov 2017 19:11:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246305#comment-16246305
] 

Daniel Templeton edited comment on YARN-7442 at 11/9/17 7:10 PM:
-----------------------------------------------------------------

Seems a fine idea, [~andrew.wang].

I'm generally OK with the format.  I'd simplify the regex to: {code}(([\w\d]([\w\d-]*[\w\d])?\.)*[\w\d]([\w\d-]*[\w\d])?)/)?\w([\w\d_.-]*){code}

Do we need to allow for dots in resource names?


was (Author: templedf):
Seems a fine idea, [~andrew.wang].

I'm generally OK with the format.  I'd simplify the regex to: {{(([\w\d]([\w\d-]*[\w\d])?\.)*[\w\d]([\w\d-]*[\w\d])?)/)?\w([\w\d_.-]*)
}}

Do we need to allow for dots in resource names?

> [YARN-7069] Limit format of resource type name
> ----------------------------------------------
>
>                 Key: YARN-7442
>                 URL: https://issues.apache.org/jira/browse/YARN-7442
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Blocker
>
> I think we should limit format of resource type name. Otherwise it could be very hard
to update in the future after release. 
> I propose to have format:
> {code}
> [a-zA-Z0-9][a-zA-Z0-9_.-/]*
> {code}
> Adding this check to setResourceInformation might affect performance a lot. Probably
we can add to {{ResourceUtils#initializeResourcesMap}} when resource types are loaded from
config file.
> [~templedf]/[~sunilg].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message