hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7442) [YARN-7069] Limit format of resource type name
Date Mon, 06 Nov 2017 17:24:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240577#comment-16240577
] 

Daniel Templeton commented on YARN-7442:
----------------------------------------

This format allows for wholly numeric resource names, like 00123.  Is that intentional?

> [YARN-7069] Limit format of resource type name
> ----------------------------------------------
>
>                 Key: YARN-7442
>                 URL: https://issues.apache.org/jira/browse/YARN-7442
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Wangda Tan
>            Priority: Blocker
>
> I think we should limit format of resource type name. Otherwise it could be very hard
to update in the future after release. 
> I propose to have format:
> {code}
> [a-zA-Z0-9][a-zA-Z0-9_.-/]*
> {code}
> Adding this check to setResourceInformation might affect performance a lot. Probably
we can add to {{ResourceUtils#initializeResourcesMap}} when resource types are loaded from
config file.
> [~templedf]/[~sunilg].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message