hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yufei Gu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7390) All reservation related test cases failed when TestYarnClient runs against Fair Scheduler.
Date Fri, 03 Nov 2017 17:16:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238023#comment-16238023
] 

Yufei Gu commented on YARN-7390:
--------------------------------

Thanks for the review, [~haibo.chen]. Uploaded patch v3 for all comments.
{quote}
 Some unit test methods use conf from ParameterizedSchedulerTestBase, whereas all reservation-based
ones use a new
configuration from setMiniYarnCluster. Do you think it is cleaner to have another class that
contains all reservation-based
tests and the existing TestYarnClient just have the rest?
{quote}
I actually spent at least 1 hour to tried that idea. Overall, it's too much for this JIRA.

# Need to refactor class {{ParameterizedSchedulerTestBase}} largely. The most tricky part
is that you need to initialize mini-yarn-cluster with an {{CapacitySchedulerConfiguration}}
object, which isn't a subclass of {{YarnConfiguration}}. There must be some hardcode for Capacity
scheduler in mini yarn cluster. I don't want to dive deep into that part in this JIRA. {{ParameterizedSchedulerTestBase}}
will be ugly anyway without solving this issue. 
# Too much work to separate the class {{TestYarnClient}}.

> All reservation related test cases failed when TestYarnClient runs against Fair Scheduler.
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-7390
>                 URL: https://issues.apache.org/jira/browse/YARN-7390
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler, reservation system
>    Affects Versions: 2.9.0, 3.0.0, 3.1.0
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>            Priority: Major
>         Attachments: YARN-7390.001.patch, YARN-7390.002.patch, YARN-7390.003.patch
>
>
> All reservation related test cases failed when {{TestYarnClient}} runs against Fair Scheduler.
To reproduce it, you need to set scheduler class to Fair Scheduler in yarn-default.xml.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message