hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gergely Novák (JIRA) <j...@apache.org>
Subject [jira] [Commented] (YARN-7370) Preemption properties should be refreshable
Date Thu, 02 Nov 2017 11:56:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235613#comment-16235613

Gergely Novák commented on YARN-7370:

Added the above 4 properties to the log statement in patch #3.

As for the float-double change, if you check the {{ProportionalCapacityPreemptionPolicy}}
code, both of the modified default properties are used with getDouble() methods, meaning that
they are automatically converted to double (and neither {{DEFAULT_PREEMPTION_MAX_IGNORED_OVER_CAPACITY}}
nor {{DEFAULT_PREEMPTION_NATURAL_TERMINATION_FACTOR}} is used anywhere else in the codebase)
- so I didn't actually change the type that is actually used (the type of {{maxIgnoredOverCapacity}}
and {{naturalTerminationFactor}} was and still is double). The reason I changed the default
constants is the precision problem of the automatic conversion: 0.1 becomes 0.10000000149011612
and it looked funny in the newly introduced log message.

> Preemption properties should be refreshable
> -------------------------------------------
>                 Key: YARN-7370
>                 URL: https://issues.apache.org/jira/browse/YARN-7370
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler, scheduler preemption
>    Affects Versions: 2.8.0, 3.0.0-alpha3
>            Reporter: Eric Payne
>            Assignee: Gergely Novák
>            Priority: Major
>         Attachments: YARN-7370.001.patch, YARN-7370.002.patch, YARN-7370.003.patch
> At least the properties for {{max-allowable-limit}} and {{minimum-threshold}} should
be refreshable. It would also be nice to make {{intra-queue-preemption.enabled}} and {{preemption-order-policy}}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message