hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types
Date Fri, 17 Nov 2017 21:50:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257629#comment-16257629
] 

Daniel Templeton commented on YARN-7119:
----------------------------------------

# ResourceUtils:L24, javadoc summary must end with a period.
# ResoursceUtils:L26, javadoc should be specific about the return value, i.e. array element
0 is...
# ResourceUtlis:L60, param summary should start with a lower case letter
# ResourceUtlis:L61, throws needs a summary
# RMAdminCLI:L207,L208, param summary should start with a lower case letter
# RMAdminCLI:L211,L212, throws needs a summary
# It looks like my suggestion about moving the + around (#10) was incomplete.  I was reviewing
the patch in the browser, so I didn't see that there are a bunch of other lines there with
the + at the end.  Would you mind just making them all consistent (with the plus at the beginning).

> yarn rmadmin -updateNodeResource should be updated for resource types
> ---------------------------------------------------------------------
>
>                 Key: YARN-7119
>                 URL: https://issues.apache.org/jira/browse/YARN-7119
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>    Affects Versions: YARN-3926
>            Reporter: Daniel Templeton
>            Assignee: Manikandan R
>         Attachments: YARN-7119.001.patch, YARN-7119.002.patch, YARN-7119.002.patch, YARN-7119.003.patch,
YARN-7119.004.patch, YARN-7119.004.patch, YARN-7119.005.patch, YARN-7119.006.patch, YARN-7119.007.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message