hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types
Date Fri, 17 Nov 2017 17:37:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257286#comment-16257286
] 

Daniel Templeton commented on YARN-7119:
----------------------------------------

bq. Currently if there is any non-alpha characters in units, still we extract the value part
safely with units as "".

Exactly.  If I ask for "1024 Mi." you're going to quietly give me "1024".  You should instead
raise the misconfig as an error.

bq. Point no. #11 will ensure arg[2] contains only numeric. But this check is required to
ensure that key value (with "=" as delimiter) pairs has been passed.

In the new patch (007) my original #12 concern is no longer valid.  I see your point now that
it didn't apply with 006 either.  I was discounting the regex match in the _else if_.

> yarn rmadmin -updateNodeResource should be updated for resource types
> ---------------------------------------------------------------------
>
>                 Key: YARN-7119
>                 URL: https://issues.apache.org/jira/browse/YARN-7119
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>    Affects Versions: YARN-3926
>            Reporter: Daniel Templeton
>            Assignee: Manikandan R
>         Attachments: YARN-7119.001.patch, YARN-7119.002.patch, YARN-7119.002.patch, YARN-7119.003.patch,
YARN-7119.004.patch, YARN-7119.004.patch, YARN-7119.005.patch, YARN-7119.006.patch, YARN-7119.007.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message