hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantinos Karanasos (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6595) [API] Add Placement Constraints at the application level
Date Tue, 07 Nov 2017 01:42:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241328#comment-16241328

Konstantinos Karanasos commented on YARN-6595:

Thanks for the patch, [~asuresh].

It looks good, some minor comments only:
* Let's remove the test from the {{BasePBImplRecordsTest}}. I think we can add a simple test
at the {{TestAMRMClient}}.
* In {{RegisterApplicationMasterRequest}}, rename to get/setPlacementConstraints (Map is not
really needed in the naming), and add some comments.
* Change the first lines of the equals of CardinalityConstraint to be the same as the other
classes (do the !instanceof instead of the ==null and getClass()).
* Some line refactoring in {{RegisterApplicationMasterRequestPBImpl}} is not needed.
* In {{RegisterApplicationMasterRequest}}, import the Unstable interface as we do for the
Stable already.

> [API] Add Placement Constraints at the application level
> --------------------------------------------------------
>                 Key: YARN-6595
>                 URL: https://issues.apache.org/jira/browse/YARN-6595
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Konstantinos Karanasos
>            Assignee: Arun Suresh
>         Attachments: YARN-6595-YARN-6592.001.patch, YARN-6595-YARN-6592.002.patch, YARN-6595-YARN-6592.003.patch,
> This JIRA allows placement constraints to be specified at the application level.
> This will be used for placement constraints between different components of the application.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message