Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 17 Oct 2017 16:45:00 +0000 (UTC)
From: "Eric Yang (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13102413.1505428859000.17661.1508258700977@Atlassian.JIRA>
In-Reply-To: <JIRA.13102413.1505428859000@Atlassian.JIRA>
References: <JIRA.13102413.1505428859000@Atlassian.JIRA> <JIRA.13102413.1505428859601@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-7202) Add UT for api-server
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 17 Oct 2017 16:45:10 -0000


    [ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207889#comment-16207889 ] 

Eric Yang commented on YARN-7202:
---------------------------------

[~gsaha] In the patch, there is no removal of ERROR_CODE_APP_*, and these codes are not valid REST API HTTP code.  I am puzzled on how the diagnostic code are sent, if web status code is designed to return NO_CONTENT.  Both designs are contradiction to each other.

Like Billie said, stopService, and no-ops both reported NO_CONTENT for PUT method.  This was a confusing API that we can not determine if a operation or configuration changes had been performed.  This is the reason that we report OK to make sure if a stop event did occur for PUT method.  The ambiguous problem came from the design of REST API to overload PUT operation with multiple purposes.  This is the reason that YARN-7215, and YARN-7217 are proposed to simplify PUT operation into additional API calls to reduce the ambiguous problem exist in the current implementation.

We can return to NO_CONTENT code with one condition.  If the PUT method is atomic operation without multiple intend, then NO_CONTENT can be used to clearly report the intended operation has been performed.  This is not how the code was written for ApiServer, and YARN-7217 was filed to polish the limitations.  This unit test patch helped to uncover the design issues early, and we can move forward with reasonable enhancement suggestion in YARN-7217.

> Add UT for api-server
> ---------------------
>
>                 Key: YARN-7202
>                 URL: https://issues.apache.org/jira/browse/YARN-7202
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Eric Yang
>             Fix For: yarn-native-services
>
>         Attachments: YARN-7202.yarn-native-services.001.patch, YARN-7202.yarn-native-services.002.patch, YARN-7202.yarn-native-services.003.patch, YARN-7202.yarn-native-services.004.patch, YARN-7202.yarn-native-services.005.patch, YARN-7202.yarn-native-services.006.patch, YARN-7202.yarn-native-services.007.patch, YARN-7202.yarn-native-services.008.patch, YARN-7202.yarn-native-services.011.patch, YARN-7202.yarn-native-services.012.patch, YARN-7202.yarn-native-services.013.patch, YARN-7202.yarn-native-services.014.patch
>
>


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org