Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 19 Oct 2017 22:55:00 +0000 (UTC)
From: "Subru Krishnan (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12996782.1470955553000.13299.1508453700903@Atlassian.JIRA>
In-Reply-To: <JIRA.12996782.1470955553000@Atlassian.JIRA>
References: <JIRA.12996782.1470955553000@Atlassian.JIRA> <JIRA.12996782.1470955553341@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-5516) Add REST API for periodicity
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 19 Oct 2017 22:55:06 -0000


    [ https://issues.apache.org/jira/browse/YARN-5516?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16211=
890#comment-16211890 ]=20

Subru Krishnan commented on YARN-5516:
--------------------------------------

Thanks [~seanpo03] for the patch. It looks mostly good except for some mino=
r comments:
* You'll have to rebase now that YARN-7311 is in.
* Can you update the REST API documentation also to include recurrence expr=
ession.
* I see you have added a test but would it be possible to run the existing =
tests with both recurrence and non-recurrence. In the case of former, the r=
eservation will repeat periodically which can be checked by wrapping the as=
sertions in a loop on periodicity.

Additionally I agree that we have to update {{ReservationDefinition}} API d=
ocumentation with the constraints you observed:
# Recurrence expression as a long must be greater than the duration (deadli=
ne =E2=80=93 arrival).
# MAX_PERIOD must be divisible by the recurrence expression.

We already have covered (1) in {{ReservationInputValidator}}. Can you make =
(2) is also there? If not, please add it (along with {{TestReservationInput=
Validator}}.

Thanks!


> Add REST API for periodicity
> ----------------------------
>
>                 Key: YARN-5516
>                 URL: https://issues.apache.org/jira/browse/YARN-5516
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Sangeetha Abdu Jyothi
>            Assignee: Sean Po
>         Attachments: YARN-5516.v001.patch, YARN-5516.v002.patch
>
>
> YARN-5516 changing REST API of the reservation system to support periodic=
ity.=20


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org