hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7394) Merge code paths for Reservation/Plan queues and Auto Created queues
Date Mon, 30 Oct 2017 23:41:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225986#comment-16225986
] 

Wangda Tan commented on YARN-7394:
----------------------------------

[~suma.shivaprasad], 

Thanks for updating the patch, few comments:
1) Instead of adding {{validate}}, probably it's easier to let PlanQueue overwrite {{reinitialize}}.

2) Can we move setEntitlement to AutoCreatedLeafQueue. 

Beyond that, patch looks good to me. [~subru]/[~curino], wanna take a look?

> Merge code paths for Reservation/Plan queues and Auto Created queues
> --------------------------------------------------------------------
>
>                 Key: YARN-7394
>                 URL: https://issues.apache.org/jira/browse/YARN-7394
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacity scheduler
>            Reporter: Suma Shivaprasad
>            Assignee: Suma Shivaprasad
>         Attachments: YARN-7394.1.patch, YARN-7394.2.patch, YARN-7394.4.patch, YARN-7394.5.patch,
YARN-7394.patch
>
>
> The initialization/reinitialization logic for ReservationQueue and AutoCreated Leaf queues
are similar. The proposal is to rename ReservationQueue to a more generic name AutoCreatedLeafQueue
which are either managed by PlanQueue(already exists) or AutoCreateEnabledParentQueue (new
class). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message