hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7384) Remove apiserver cmd and merge service cmd into application cmd
Date Fri, 27 Oct 2017 07:27:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221862#comment-16221862
] 

Jian He commented on YARN-7384:
-------------------------------

looks good overall, some minor comments:
- I found there's a java lib for this Arrays.copyOfRange()
{code}
      String[] newArgs = new String[args.length - 1];
      for (int i = 1; i < args.length; i++) {
        newArgs[i-1] = args[i];
      }
      return newArgs;
{code}
- didn't get this, could you clarify more ?
{code}
     //  first argument (app|application|applicationattempt|container) must
     //  be stripped off for GenericOptionsParser to work
{code}
- I don't get this part, could you explain? In preProcessArgs, if args.length > 0, then
firstArg != null, these two conditions will both be true ?
{code}
    if (firstArg != null) {
      title = firstArg;
    } else if (args.length > 0) {
      title = args[0];
    }
{code}

- rename getSingleAppType -> getSingleAppTypeFromCLI ?


> Remove apiserver cmd and merge service cmd into application cmd
> ---------------------------------------------------------------
>
>                 Key: YARN-7384
>                 URL: https://issues.apache.org/jira/browse/YARN-7384
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>         Attachments: YARN-7384-yarn-native-services.001.patch, YARN-7384-yarn-native-services.002.patch,
YARN-7384-yarn-native-services.003.patch
>
>
> As per discussion on YARN-7326.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message