hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haibo Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7373) The atomicity of container update in RM is not clear
Date Mon, 23 Oct 2017 18:27:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215598#comment-16215598
] 

Haibo Chen commented on YARN-7373:
----------------------------------

Thanks [~asuresh] for the detailed information! Agreed that we should lock the node around
the container update calls. I'll address the issue in YARN-4511. Closing this.

> The atomicity of container update in RM is not clear
> ----------------------------------------------------
>
>                 Key: YARN-7373
>                 URL: https://issues.apache.org/jira/browse/YARN-7373
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>            Reporter: Haibo Chen
>            Assignee: Haibo Chen
>
> While reviewing YARN-4511, Miklos noticed that  
> {code:java}
> 342	    // notify schedulerNode of the update to correct resource accounting
> 343	    node.containerUpdated(existingRMContainer, existingContainer);
> 344	
> 345	    ((RMContainerImpl)tempRMContainer).setContainer(updatedTempContainer);
> 346	    // notify SchedulerNode of the update to correct resource accounting
> 347	    node.containerUpdated(tempRMContainer, tempContainer);
> 348	
> {code}
> bq. I think that it would be nicer to lock around these two calls to become atomic.
> Container update, and thus container swap as part of that, is atomic according to [~asuresh].
> It'd be nice to discuss this in more details to see if we want to be more conservative.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message