hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7353) Docker permitted volumes don't properly check for directories
Date Fri, 20 Oct 2017 19:44:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213117#comment-16213117
] 

Hudson commented on YARN-7353:
------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13118 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/13118/])
YARN-7353. Improved volume mount check for directories and unit test (eyang: rev b61144a93d9306624378a93944d0a08c60436554)
* (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c
* (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/utils/test_docker_util.cc


> Docker permitted volumes don't properly check for directories
> -------------------------------------------------------------
>
>                 Key: YARN-7353
>                 URL: https://issues.apache.org/jira/browse/YARN-7353
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>         Attachments: YARN-7353.001.patch, YARN-7353.002.patch, YARN-7353.003.patch
>
>
> {noformat:title=docker-util.c:check_mount_permitted()}
>     // directory check
>     permitted_mount_len = strlen(permitted_mounts[i]);
>     if (permitted_mount_len > 0
>         && permitted_mounts[i][permitted_mount_len - 1] == '/') {
>       if (strncmp(normalized_path, permitted_mounts[i], permitted_mount_len) == 0) {
>         ret = 1;
>         break;
>       }
>     }
> {noformat}
> This code will treat "/home/" as a directory, but not "/home"
> {noformat}
> [  FAILED  ] 3 tests, listed below:
> [  FAILED  ] TestDockerUtil.test_check_mount_permitted
> [  FAILED  ] TestDockerUtil.test_normalize_mounts
> [  FAILED  ] TestDockerUtil.test_add_rw_mounts
> {noformat}
> Additionally, YARN-6623 introduced new test failures in the C++ container-executor test
"cetest"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message