hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7289) Application lifetime does not work with FairScheduler
Date Wed, 25 Oct 2017 17:46:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219173#comment-16219173
] 

Daniel Templeton commented on YARN-7289:
----------------------------------------

Here:

{code}
      if (scheduler.equals(CapacityScheduler.class)) {
        newConf =
            new YarnConfiguration(setUpCSQueue(maxLifetime, defaultLifetime));
        conf = new YarnConfiguration(newConf);
      }
{code}

Do we need the intermediary conf?  Can't we just have:

{code}
      if (scheduler.equals(CapacityScheduler.class)) {
        conf = new YarnConfiguration(setUpCSQueue(maxLifetime, defaultLifetime));
      }
{code}

?

It would also be good to add a comment to say why FS doesn't need any queue setup.

Is {{testApplicationLifetimeMonitor()}} actually testing anything with FS?  Would it be a
better approach to add an {{assume()}} so the test only runs with CS?

> Application lifetime does not work with FairScheduler
> -----------------------------------------------------
>
>                 Key: YARN-7289
>                 URL: https://issues.apache.org/jira/browse/YARN-7289
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>            Reporter: Miklos Szegedi
>            Assignee: Miklos Szegedi
>         Attachments: YARN-7289.000.patch, YARN-7289.001.patch, YARN-7289.002.patch, YARN-7289.003.patch,
YARN-7289.004.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message