hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7286) Add support for docker to have no capabilities
Date Tue, 10 Oct 2017 16:03:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198880#comment-16198880
] 

Jason Lowe commented on YARN-7286:
----------------------------------

Yeah, the core problem with trying to use empty as a value was YARN-4258 set a precedence
for the default value to be DEFAULT_NM_DOCKER_CONTAINER_CAPABILITIES, a significant list of
capabilites by default.  The closest we could get is to leave the default in yarn-default.xml
to be the current list in DEFAULT_NM_DOCKER_CONTAINER_CAPABILITIES but treat an empty/unset
property as no capability.  That would technically be incompatible with the behavior in YARN-4258,
and users would still have to explicitly unset the property or set it to an empty string to
get nothing rather than getting nothing by default.  However I think it's probably rare for
someone to be explicitly unsetting this property today or setting it to an empty string and
expecting the large list of capabilities in DEFAULT_NM_DOCKER_CONTAINER_CAPABILITIES to be
picked up.  Pinging [~sidharta-s] and [~vvasudev] since they worked on YARN-4258 and may have
opinions on how best to allow no capabilities to be set.

If we decide to keep with the "none" approach, given other properties can be specified case-insensitive,
I think it would be consistent to allow either "none" or "NONE" as a value.


> Add support for docker to have no capabilities
> ----------------------------------------------
>
>                 Key: YARN-7286
>                 URL: https://issues.apache.org/jira/browse/YARN-7286
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>         Attachments: YARN-7286.001.patch, YARN-7286.002.patch, YARN-7286.003.patch
>
>
> Support for controlling capabilities was introduced in YARN-4258. However, it does not
allow for the capabilities list to be NULL, since {{getStrings()}} will treat an empty value
the same as it treats an unset property. So, a NULL list will actually give the default capabilities
list.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message