hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7276) Federation Router Web Service fixes
Date Fri, 20 Oct 2017 20:40:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213197#comment-16213197
] 

Subru Krishnan commented on YARN-7276:
--------------------------------------

Thanks [~elgoiri] for the fixes. I looked at it and is mostly good, minor comments below:
* DefaultMetricsSystem initialization seems to be missing in the patch.
* Add tests to check empty states and labels?
* Would it be possible to have a multi-threaded test?
* Nit: {{FederationInterceptorREST::getCopy}} --> {{FederationInterceptorREST::Clone}}
and mention in the comment that this is for thread safeness. 

> Federation Router Web Service fixes
> -----------------------------------
>
>                 Key: YARN-7276
>                 URL: https://issues.apache.org/jira/browse/YARN-7276
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>         Attachments: YARN-7276.000.patch, YARN-7276.001.patch, YARN-7276.002.patch
>
>
> While testing YARN-3661, I found a few issues with the REST interface in the Router:
> * No support for empty content (error 204)
> * Media type support
> * Attributes in {{FederationInterceptorREST}}
> * Support for empty states and labels
> * DefaultMetricsSystem initialization is missing



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message