hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7202) End-to-end UT for api-server
Date Mon, 09 Oct 2017 23:22:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197860#comment-16197860
] 

Jian He commented on YARN-7202:
-------------------------------

confused, isn't this code not part of this patch ? I did clean before build.
Can you try compile only this patch with the dependency removed? 
{code}
[ERROR] /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api/src/test/java/org/apache/hadoop/yarn/service/ServiceClientTest.java:[29,45]
cannot find symbol
[ERROR]   symbol:   class YarnSolrClientTest
{code}

bq.  The new code enables the logic to be handled more accurately and provide better status
report to down stream program weather the failure is caused by a bad request, record not found,
or undetermined server errors. The previous implementation does not allow certain error to
be surfaced correctly.
Confused. I'm seeing the opposite. 
Before the patch, it directly returns the status code based on whatever failure conditions
it is inside the method which is accurate.
After the patch, it only returns INTERNAL_SERVER_ERROR or BAD_REQUEST.  e.g. the NOT_FOUND
 status code for stopService method is instead converted to the BAD_REQUEST status code. 
Why is this converstion needed? 

> End-to-end UT for api-server
> ----------------------------
>
>                 Key: YARN-7202
>                 URL: https://issues.apache.org/jira/browse/YARN-7202
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Eric Yang
>         Attachments: YARN-7202.yarn-native-services.001.patch, YARN-7202.yarn-native-services.002.patch,
YARN-7202.yarn-native-services.003.patch, YARN-7202.yarn-native-services.004.patch, YARN-7202.yarn-native-services.005.patch,
YARN-7202.yarn-native-services.006.patch, YARN-7202.yarn-native-services.007.patch, YARN-7202.yarn-native-services.008.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message