hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types
Date Sun, 29 Oct 2017 04:49:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223839#comment-16223839
] 

Sunil G commented on YARN-7119:
-------------------------------

Thanks [~manirajv06@gmail.com]

Few comments
# {{CapacitySchedulerConfiguration.getUnits}} could be used instead of replicating same in
ResourceUtils.
# {{-updateNodeResource}} is not related to resource-profiles feature enable/disable boolean
flag. We have resource types and resource profiles as separate features and config is only
for profiles. YARN by default will support multiple resource types if resoruce-types.xml is
supplied. So pls update the help in RMAdminCLI and remove the profile flag check.
# checkMandatoryResources in RMAdminCLI should be reused or make it as common as possible
to ResourceUtils
# RMAdminCLI#createResource is more or less parsing the resource types from incoming string
and creating a resource out of it. So lets say it as parseCommandAndCreateResource


> yarn rmadmin -updateNodeResource should be updated for resource types
> ---------------------------------------------------------------------
>
>                 Key: YARN-7119
>                 URL: https://issues.apache.org/jira/browse/YARN-7119
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>    Affects Versions: YARN-3926
>            Reporter: Daniel Templeton
>            Assignee: Manikandan R
>         Attachments: YARN-7119.001.patch, YARN-7119.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message