hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5516) Add REST API for periodicity
Date Thu, 19 Oct 2017 22:55:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211890#comment-16211890
] 

Subru Krishnan commented on YARN-5516:
--------------------------------------

Thanks [~seanpo03] for the patch. It looks mostly good except for some minor comments:
* You'll have to rebase now that YARN-7311 is in.
* Can you update the REST API documentation also to include recurrence expression.
* I see you have added a test but would it be possible to run the existing tests with both
recurrence and non-recurrence. In the case of former, the reservation will repeat periodically
which can be checked by wrapping the assertions in a loop on periodicity.

Additionally I agree that we have to update {{ReservationDefinition}} API documentation with
the constraints you observed:
# Recurrence expression as a long must be greater than the duration (deadline – arrival).
# MAX_PERIOD must be divisible by the recurrence expression.

We already have covered (1) in {{ReservationInputValidator}}. Can you make (2) is also there?
If not, please add it (along with {{TestReservationInputValidator}}.

Thanks!




> Add REST API for periodicity
> ----------------------------
>
>                 Key: YARN-5516
>                 URL: https://issues.apache.org/jira/browse/YARN-5516
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Sangeetha Abdu Jyothi
>            Assignee: Sean Po
>         Attachments: YARN-5516.v001.patch, YARN-5516.v002.patch
>
>
> YARN-5516 changing REST API of the reservation system to support periodicity. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message