hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Badger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5366) Add support for toggling the removal of completed and failed docker containers
Date Fri, 13 Oct 2017 21:38:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204230#comment-16204230
] 

Eric Badger commented on YARN-5366:
-----------------------------------

Hey [~shanekumpf@gmail.com], reading over this JIRA again and found some useful information.

bq. After doing additional testing here, adding --rm to docker run will not work. Detached
mode combined with cleanup container on exit options are not supported together. As a result,
we'll need a bit more control over the lifecycle.
Looks like this got fixed by https://github.com/moby/moby/pull/20848 such that the options
can work together. 

However, why is it that we're running docker containers in detached mode anyway? Is this a
requirement? If we don't need to run in detached mode then we don't need to worry about these
params interfering with each other and can easily implement this feature by a simple property
in container-executor.cfg

> Add support for toggling the removal of completed and failed docker containers
> ------------------------------------------------------------------------------
>
>                 Key: YARN-5366
>                 URL: https://issues.apache.org/jira/browse/YARN-5366
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Shane Kumpf
>            Assignee: Shane Kumpf
>              Labels: oct16-medium
>         Attachments: YARN-5366.001.patch, YARN-5366.002.patch, YARN-5366.003.patch, YARN-5366.004.patch,
YARN-5366.005.patch, YARN-5366.006.patch
>
>
> Currently, completed and failed docker containers are removed by container-executor.
Add a job level environment variable to DockerLinuxContainerRuntime to allow the user to toggle
whether they want the container deleted or not and remove the logic from container-executor.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message