hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4163) Audit getQueueInfo and getApplications calls
Date Thu, 12 Oct 2017 16:09:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202180#comment-16202180
] 

Jason Lowe commented on YARN-4163:
----------------------------------

Thanks for updating the patch!  The builder pattern solves the ordering problem nicely.

The more I look at it, the more I'm torn on the addition of the new args functionality.  Looking
at the existing keys or even the new QUEUE key that is being added as part of this patch,
arguably most of them can be considered as arguments to the particular OPERATION.  That makes
the addition of the new {{includeApplications}}, {{includeChildQueues}}, and {{recursive}}
arguments inconsistent with the others.  They're not upper case, so they stick out.  Why is
QUEUE upper case but other arguments in the client request are not?  I think logged keys should
be consistent or it is going to seem arbitrarily different to end users.  Making these new
args keys also helps cement them a bit more from a compatibility perspective.  The args builder
pattern could be updated to take a Key enum rather than an arbitrary string.  Thoughts?  I
could also see going with a new ARGS key that lists the arguments, although that makes it
a bit less cemented with respect to log format and backwards-compatibility.

The "Use List to preserve order." comment is no longer necessary

It would be good to clean up the checkstyle issues not related to arg counts, although if
we do go with the builder pattern for generating logs then it could make sense to address
that as well.

> Audit getQueueInfo and getApplications calls
> --------------------------------------------
>
>                 Key: YARN-4163
>                 URL: https://issues.apache.org/jira/browse/YARN-4163
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Chang Li
>            Assignee: Chang Li
>         Attachments: YARN-4163.004.patch, YARN-4163.005.patch, YARN-4163.006.branch-2.8.patch,
YARN-4163.006.patch, YARN-4163.2.patch, YARN-4163.2.patch, YARN-4163.3.patch, YARN-4163.patch
>
>
> getQueueInfo and getApplications seem to sometimes cause spike of load but not able to
confirm due to they are not audit logged. This patch propose to add them to audit log



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message