hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4163) Audit getQueueInfo and getApplications calls
Date Tue, 03 Oct 2017 20:41:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190317#comment-16190317
] 

Jason Lowe commented on YARN-4163:
----------------------------------

Thanks for updating the patch!

It would be good to cleanup the javadoc and checkstyle issues.  In addition I think it would
be cleaner and more performant to create an audit log arg builder class rather than abuse
the Map.Entry class.  As it is now we're building a list of entries to pass to the audit logger
which then has to loop over that list passing the entries to a string builder.  Instead the
caller could build the args using something like an RMAuditLogger.ArgsBuilder class that is
essentially a wrapper around StringBuilder.  The arg builder class could have an {{add}} method
that takes a key, value pair and adds them to the string with the pair and key/val separator
characters just like is done in RMAuditLogger now.  Then when we go to log these extra args
we just need to tack one string builder onto another rather than create a list of objects
and iterate over them.



> Audit getQueueInfo and getApplications calls
> --------------------------------------------
>
>                 Key: YARN-4163
>                 URL: https://issues.apache.org/jira/browse/YARN-4163
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Chang Li
>            Assignee: Chang Li
>         Attachments: YARN-4163.004.patch, YARN-4163.2.patch, YARN-4163.2.patch, YARN-4163.3.patch,
YARN-4163.patch
>
>
> getQueueInfo and getApplications seem to sometimes cause spike of load but not able to
confirm due to they are not audit logged. This patch propose to add them to audit log



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message