Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 26 Sep 2017 22:53:00 +0000 (UTC)
From: "Eric Yang (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13102413.1505428859000.209862.1506466380182@Atlassian.JIRA>
In-Reply-To: <JIRA.13102413.1505428859000@Atlassian.JIRA>
References: <JIRA.13102413.1505428859000@Atlassian.JIRA> <JIRA.13102413.1505428859601@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (YARN-7202) End-to-end UT for api-server
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 26 Sep 2017 22:53:04 -0000


    [ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181706#comment-16181706 ] 

Eric Yang edited comment on YARN-7202 at 9/26/17 10:52 PM:
-----------------------------------------------------------

[~jianhe] The test case are designed to be unit tests for ApiServer without over reaching.  It also covers the input validation in ServiceClient.  It is possible to write additional tests to focus on ServiceClient correctness which can increase test coverage.  However, I think it is easy to mistaken unit test verse integration test.  Without good coverage at interface level, integration test may not help to identify the root problems.  I can't say I am familiar with ServiceClient code to write unit tests for it.  I can write unit tests for new code that I am about to add to ServiceClient for storing Service spec.  However, it would be helpful for original author who wrote ServiceClient to add test code.


was (Author: eyang):
[~jianhe] The test case are designed to be unit tests for ApiServer without over reaching.  It also covers the input validation in ServiceClient.  It is possible to write additional tests to focus on ServiceClient correctness which can increase test coverage.  However, I think it is easy to mistaken unit test verse integration test.  Without good coverage at interface level, integration test may not help to identify the root problems.  I can't say I am familiar with ServiceClient code to write unit tests for it.  I can write unit tests for new code that I am about to add to ServiceClient for storing Service config.  However, it would be helpful for original author who wrote ServiceClient to add test code.

> End-to-end UT for api-server
> ----------------------------
>
>                 Key: YARN-7202
>                 URL: https://issues.apache.org/jira/browse/YARN-7202
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>         Attachments: YARN-7202.yarn-native-services.001.patch, YARN-7202.yarn-native-services.002.patch
>
>


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org