Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 15 Sep 2017 19:13:00 +0000 (UTC)
From: "Arun Suresh (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13102386.1505423932000.125828.1505502780276@Atlassian.JIRA>
In-Reply-To: <JIRA.13102386.1505423932000@Atlassian.JIRA>
References: <JIRA.13102386.1505423932000@Atlassian.JIRA> <JIRA.13102386.1505423932067@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (YARN-7199)
 TestAMRMClientContainerRequest.testOpportunisticAndGuaranteedRequests is
 failing in trunk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 15 Sep 2017 19:13:06 -0000


    [ https://issues.apache.org/jira/browse/YARN-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168375#comment-16168375 ] 

Arun Suresh edited comment on YARN-7199 at 9/15/17 7:12 PM:
------------------------------------------------------------

Thanks for the patch [~botong]. But I think the actual issue is that the {{ContainerRequestBuilder#build}} method is not populating the resource profile field with the default value {{ProfileCapability.DEFAULT_PROFILE}}. It looks the public {{ContainerRequest}} constructors do set the default value correctly - unfortunately, the builder uses the private constructor that does not.
The proper fix should be to modify the private constructor to set the value to default AND add the resourceProfile() method in the builder, which can be used by a client to set it to something else.


was (Author: asuresh):
Thanks for the patch [~botong]. But I think the actual issue is that the {{ContainerRequestBuilder#build}} method is not populating the resource profile field with the default value {{ProfileCapability.DEFAULT_PROFILE}}. It looks the public {{ContainerRequest}} constructors that sets the value correctly - unfortunately, the builder uses the private constructor that does not.
The proper fix should be to modify the private constructor to set the value to default AND add the resourceProfile() method in the builder, which can be used by a client to set it to something else.

> TestAMRMClientContainerRequest.testOpportunisticAndGuaranteedRequests is failing in trunk
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-7199
>                 URL: https://issues.apache.org/jira/browse/YARN-7199
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Botong Huang
>            Assignee: Botong Huang
>         Attachments: YARN-7199.v1.patch, YARN-7199.v2.patch
>
>
> java.lang.IllegalArgumentException: The profile name cannot be null
> 	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
> 	at org.apache.hadoop.yarn.api.records.ProfileCapability.newInstance(ProfileCapability.java:68)
> 	at org.apache.hadoop.yarn.client.api.impl.AMRMClientImpl.addContainerRequest(AMRMClientImpl.java:512)
> 	at org.apache.hadoop.yarn.client.api.impl.TestAMRMClientContainerRequest.testOpportunisticAndGuaranteedRequests(TestAMRMClientContainerRequest.java:59)


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org