Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 188C0200D0C for ; Wed, 20 Sep 2017 17:27:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 175F11609E2; Wed, 20 Sep 2017 15:27:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 55D471609E1 for ; Wed, 20 Sep 2017 17:27:03 +0200 (CEST) Received: (qmail 4041 invoked by uid 500); 20 Sep 2017 15:27:02 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 4030 invoked by uid 99); 20 Sep 2017 15:27:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Sep 2017 15:27:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0BEB0C8D34 for ; Wed, 20 Sep 2017 15:27:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id hEDblzYCFsDf for ; Wed, 20 Sep 2017 15:27:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 404325FBDF for ; Wed, 20 Sep 2017 15:27:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CE0FFE0EA5 for ; Wed, 20 Sep 2017 15:27:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 34001218F6 for ; Wed, 20 Sep 2017 15:27:00 +0000 (UTC) Date: Wed, 20 Sep 2017 15:27:00 +0000 (UTC) From: "Miklos Szegedi (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-6968) Hard coded reference to an absolute pathname in org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.launchContainer(ContainerRuntimeContext) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 20 Sep 2017 15:27:04 -0000 [ https://issues.apache.org/jira/browse/YARN-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173337#comment-16173337 ] Miklos Szegedi commented on YARN-6968: -------------------------------------- Thank you, [~ebadger] for working on this and submitting the patch. Is there a reason to duplicate the configuration? We could use yarn.nodemanager.linux-container-executor.cgroups.mount-path or even better we could get the value from CGroupsHandler, so that it is auto detected. The path inside the container could be configurable separately indeed, however it is probably a good idea to make it configurable by the client. Also, it is interesting that the findbugs warning did not go away with the patch. > Hard coded reference to an absolute pathname in org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.launchContainer(ContainerRuntimeContext) > --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: YARN-6968 > URL: https://issues.apache.org/jira/browse/YARN-6968 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Reporter: Miklos Szegedi > Assignee: Eric Badger > Attachments: YARN-6968.001.patch, YARN-6968.002.patch > > > This could be done after YARN-6757 is checked in. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org